Skip to content

Comments

Restore lost content from PR #20#53

Merged
fm-tibco merged 1 commit intoproject-flogo:masterfrom
square-it:fix-pr#20
Mar 12, 2019
Merged

Restore lost content from PR #20#53
fm-tibco merged 1 commit intoproject-flogo:masterfrom
square-it:fix-pr#20

Conversation

@debovema
Copy link
Contributor

What kind of change does this PR introduce? (check one with "x")

[x] Bugfix
[] Feature
[] Code style update (formatting, local variables)
[] Refactoring (no functional changes, no api changes)
[] Other... Please describe:

Some content from commit 261af9b in PR #20 was lost after a rebase.

What is the current behavior?
Some optional keys are saved with a null value in flogo.json file:

  "properties": null,
  "channels": null,
  "actions": null

What is the new behavior?
If the key is optional and not present, it is not saved in flogo.json

@debovema
Copy link
Contributor Author

@fm-tibco : I saw that #52 restored the missing "omitempty" (and noticed that triggers and resources are mandatory). What about the appModel key ?

@fm-tibco fm-tibco merged commit 68824d6 into project-flogo:master Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants